Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Perspective Filter Errors #2521

Merged
merged 1 commit into from
Jul 10, 2021
Merged

Fix Perspective Filter Errors #2521

merged 1 commit into from
Jul 10, 2021

Conversation

MarcSkovMadsen
Copy link
Collaborator

I noticed at work that when I drag a column to the "Filter" it raises errors.

I can see its because the fix applied to the _process_property_change in #2300 needs to be applied to the _process_param_change method as well.

Because of #2518 I'm not able to show the behaviour before and after this fix is applied

@philippjfr . Is it possible to get this in Panel 0.12?

@codecov
Copy link

codecov bot commented Jul 10, 2021

Codecov Report

Merging #2521 (ae2480f) into master (3de416e) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2521      +/-   ##
==========================================
+ Coverage   83.30%   83.31%   +0.01%     
==========================================
  Files         184      184              
  Lines       23186    23186              
==========================================
+ Hits        19314    19317       +3     
+ Misses       3872     3869       -3     
Impacted Files Coverage Δ
panel/pane/perspective.py 54.14% <100.00%> (ø)
panel/tests/pane/test_plotly.py 98.73% <0.00%> (+0.63%) ⬆️
panel/io/reload.py 66.66% <0.00%> (+2.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3de416e...ae2480f. Read the comment docs.

@philippjfr philippjfr merged commit 100b557 into master Jul 10, 2021
@philippjfr philippjfr deleted the perspective-fixes branch July 10, 2021 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants